Skip to content

FOUR-12844: Add username to searched columns when searching for users to add to a group #6281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

runyan-co
Copy link
Contributor

@runyan-co runyan-co commented Feb 23, 2024

Issue

Previously, if you searched for users to add to a group which have very similar names, it would be difficult to find the specific user you were searching for. In this scenario, it would make sense to search by username since usernames must be unique, however the search did not consider the username column and the search result would be empty.

Reproduction Steps

Please following the reproduction steps in the related FOUR ticket.

Solution\

  • Add the username column to be one of the searched columns when searching for a user to add to a group.

How to Test

You should now be able to type in the username of a given user not in a group on the screen where you add users to a group (which aren't already in the group).

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@runyan-co runyan-co changed the base branch from develop to next February 23, 2024 17:52
@runyan-co runyan-co changed the title FOUR-12844: Add username to. searched columns when searching for users to add to a group FOUR-12844: Add username to. searched columns when searching for users to add to a group Feb 23, 2024
@runyan-co runyan-co changed the title FOUR-12844: Add username to. searched columns when searching for users to add to a group FOUR-12844: Add username to searched columns when searching for users to add to a group Feb 23, 2024
@ryancooley ryancooley merged commit f085eb9 into next Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants