Skip to content

Implement Temporary Solution for Generating Guided Template Launchpad Carousel Images #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Feb 19, 2024

This PR introduces a temporary solution for generating Guided Template Launchpad carousel images. Due to limitations in the current system where launchpad images are not exported alongside process configurations, this temporary solution utilizes the wizard-templates GitHub repo to store images related to the guided template. Upon importing the process created from the guided template, the images are synced to the newly imported process.

The changes include updates to the SyncGuidedTemplates job to handle storing the launchpad images and modifications to the import method for importing a process from a process template to add the guided template images to the processimage_carousel media collection.

How to Test

  1. Ensure your environment is configured with the correct wizard-template branch by adding GUIDED_TEMPLATE_BRANCH=task/FOUR-14171 to your .env file.
  2. Run the commands php artisan optimize and php artisan processmaker:sync-guided-templates.
  3. Navigate to Processes -> Guided Templates.
  4. Run a guided template.
  5. Upon completion and redirection to the newly created process, verify that the carousel images are loaded correctly.
  6. Run another guided template to ensure there are no image errors on subsequent process imports.

Related Tickets & Packages

ci:next

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy
ci:next
ci:wizard-templates:task/FOUR-14171
ci:GUIDED_TEMPLATE_BRANCH="task/FOUR-14171"

Copy link

processmaker-sonarqube bot commented Feb 19, 2024

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-7c5ed1dd4a.engk8s.processmaker.net

2 similar comments
@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-7c5ed1dd4a.engk8s.processmaker.net

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-7c5ed1dd4a.engk8s.processmaker.net

@pmPaulis
Copy link
Contributor

@sanjacornelius
This is working as expected, but in the revision I found a issue with the resize image but it was fixed with the ticket https://processmaker.atlassian.net/browse/FOUR-14195
Regards,

@ryancooley ryancooley merged commit d539ebd into next Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants