Skip to content

Use advanced filter for defaults and fix translations #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 20, 2024
Merged

Use advanced filter for defaults and fix translations #6244

merged 2 commits into from
Feb 20, 2024

Conversation

nolanpro
Copy link
Contributor

This PR fixes several issues

  • It uses advanced filters instead of PMQL for the default status for requests and tasks pages. Fixes 13931

These other issues were found and fixed:

  • Fixes an problem where column sorting broke when a default task and request pages are converted to system saved searches
  • Fixes translations by only translating when the string is displayed

Requires: https://github.com/ProcessMaker/package-savedsearch/pull/415

ci:next

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@nolanpro nolanpro requested a review from caleeli February 16, 2024 23:40
caleeli
caleeli approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@caleeli caleeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@ryancooley ryancooley merged commit 446aa67 into next Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caleeli caleeli caleeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nolanpro @caleeli @ryancooley