Skip to content

Remove Deprecated Code for Reassociating Data Source Scripts #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

sanjacornelius
Copy link
Contributor

@sanjacornelius sanjacornelius commented Feb 10, 2024

Issue & Reproduction Steps

This PR removes deprecated code responsible for reassociating data source scripts with the imported script. The deprecated code caused a 'Duplicate entry` error when associating the data_source_scripts from the guided template. The reassociation functionality is now handled in the data source ProcessExporterExtension file.

How to Test

  1. Ensure your instance has Guided Templates synced php artisan processmaker:sync-guided-templates
  2. Select the guided template and run the process
  3. Upon first completion of the guided template, you will be redirected to the launchpad, but to trigger the error you will need to run the guided template again to create another process
  4. Upon completion of the second guided template, you will be navigated to the 'existing assets' page.
  5. Select 'Continue'
  6. Select 'Yes'
  7. Ensure no errors appear and the process is successfully created and you are redirected to the process launchpad.

Related Tickets & Packages

ci:next
ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

This commit removes deprecated code responsible for reassociating data source scripts with the imported script. The functionality should be handled in the data source ProcessExporterExtension file.
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@tokensPM
Copy link

QA server K8S was successfully deployed https://ci-0a0c8f97a3.engk8s.processmaker.net

Copy link
Contributor

@estebangallego estebangallego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ryancooley ryancooley merged commit 5f4bf17 into next Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants