Skip to content

FOUR-14077: Update the URL of Launchpad #6181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 14, 2024
Merged

FOUR-14077: Update the URL of Launchpad #6181

merged 9 commits into from
Feb 14, 2024

Conversation

pmPaulis
Copy link
Contributor

@pmPaulis pmPaulis commented Feb 7, 2024 •
edited
Loading

Issue & Reproduction Steps

Update the URL of Launchpad

Solution

  • List the changes you've introduced to solve the issue.

How to Test

Review the URL for processes

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:next

@tokensPM
Copy link

tokensPM commented Feb 7, 2024

QA server K8S was successfully deployed https://ci-fd82a7058d.engk8s.processmaker.net

@pmPaulis pmPaulis requested a review from eiresendez February 8, 2024 19:10
@pmPaulis
Copy link
Contributor Author

pmPaulis commented Feb 8, 2024

@eiresendez
Please Could you doble check this change?
Regards,

@ryancooley
Copy link
Contributor

@pmPaulis Could this URL be hardcoded anywhere that might cause an instance on 4.9.x to fail when upgraded to 4.9.2?

@ryancooley ryancooley added the question Further information is requested label Feb 8, 2024
@tokensPM
Copy link

tokensPM commented Feb 9, 2024

QA server K8S was successfully deployed https://ci-fd82a7058d.engk8s.processmaker.net

@tokensPM
Copy link

tokensPM commented Feb 9, 2024

QA server K8S was successfully deployed https://ci-fd82a7058d.engk8s.processmaker.net

pmPaulis
pmPaulis commented Feb 9, 2024
View reviewed changes
@pmPaulis
Copy link
Contributor Author

pmPaulis commented Feb 9, 2024 •
edited
Loading

recording.webm

caleeli
caleeli reviewed Feb 9, 2024
View reviewed changes
@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@pmPaulis
Copy link
Contributor Author

pmPaulis commented Feb 9, 2024 •
edited
Loading

@ryancooley
We have added defensive code for the use case with backward compatibility

@ryancooley ryancooley removed the question Further information is requested label Feb 14, 2024
@ryancooley ryancooley merged commit 8f5641a into next Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fagubla fagubla fagubla approved these changes

@caleeli caleeli caleeli approved these changes

@eiresendez eiresendez eiresendez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pmPaulis @tokensPM @ryancooley @fagubla @caleeli @eiresendez @luNunezProcessmaker