Skip to content

Refactor some parts of the column filtering functionality #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Feb 8, 2024
Merged

Refactor some parts of the column filtering functionality #6152

merged 20 commits into from
Feb 8, 2024

Conversation

nolanpro
Copy link
Contributor

@nolanpro nolanpro commented Feb 5, 2024 •
edited by jira bot
Loading

  • Add badges to show the filters applied to the tasks and requests page
  • Adds the filter configs to the column definitions so we can get rid of all the Alias overrides
  • Applies aliases only when fetching results
  • Makes process search a free-form text field instead of a list of dropdowns FOUR-13977

Requires https://github.com/ProcessMaker/package-savedsearch/pull/408
ci:next

@nolanpro nolanpro changed the title Refactor Refactor some parts of the column filtering functionality Feb 5, 2024
@nolanpro nolanpro requested a review from gproly February 5, 2024 17:02
@nolanpro nolanpro mentioned this pull request Feb 6, 2024
Closed
9 tasks
gproly
gproly approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@gproly gproly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@processmaker-sonarqube ProcessMaker SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% 0.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@ryancooley ryancooley merged commit e83bc3f into next Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gproly gproly gproly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nolanpro @gproly @ryancooley @agustinbusso