Skip to content

FOUR-13969: Allow user to decide what to do with the Screen Interstitial when importing assets #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2024

Conversation

estebangallego
Copy link
Contributor

@estebangallego estebangallego commented Jan 31, 2024

Issue & Reproduction Steps

When following the guided template process, it has been noticed that the interstitial screen does show within the TemplateAssets check and it's been duplicated multiple times.

Interstitial screens should be part of the initial existing assets check, so the user can decide if they’ll be updated, replaced, or if a new version should be created

Solution

  • Allow Screen Interstitial to display within the TemplateAssets table.

How to Test

  • Navigate to Processes
  • Navigate to Guided Templates
  • Select the Guided Invoice Approval
  • Follow all the steps
    Please ensure that the user has the option of what to do with the Interstitial Screen.
    Please make sure that each selection works as expected. (Update | Keep Previous | Duplicate)

Screenshot 2024-01-31 at 5 22 10 PM

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@estebangallego estebangallego changed the title FOUR-13969: Remove check of the Screen Interstitial when importing assets FOUR-13969: Allow user to decide what to do with the Screen Interstitial when importing assets Jan 31, 2024
@eiresendez eiresendez self-requested a review February 1, 2024 14:33
@eiresendez eiresendez self-requested a review February 1, 2024 16:17
Copy link
Contributor

@eiresendez eiresendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

Copy link

@ryancooley ryancooley merged commit fafc3ed into next Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants