FOUR-11415 Password Policy Configuration #5682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julceslauhub
force-pushed
the
FOUR-11415
branch
from
f2f9738 to
02a4fcc
Compare
julceslauhub
force-pushed
the
FOUR-11415
branch
from
02a4fcc to
b5b4d50
Compare
caleeli
reviewed
Nov 23, 2023
| @@ -54,7 +54,7 @@ | |||
| {!! Form::label('confPassword', __('Confirm Password')) !!} | |||
| {!! Form::password('confPassword', ['id' => 'confPassword', 'rows' => 4, 'class'=> 'form-control', 'v-model' | |||
| => 'formData.confPassword', 'autocomplete' => 'new-password', 'v-bind:class' => '{\'form-control\':true, \'is-invalid\':errors.password}']) !!} | |||
| <div class="invalid-feedback" :style="{display: (errors.password) ? 'block' : 'none' }" role="alert" v-if="errors.password">@{{errors.password[0]}}</div> | |||
| <div class="invalid-feedback" :style="{display: (errors.password) ? 'block' : 'none' }" role="alert" v-for="(error, index) in errors.password">@{{error}}</div> | |||
There was a problem hiding this comment.
Please split thi line in multiple lines to enhance readability
caleeli
requested changes
Nov 23, 2023
There was a problem hiding this comment.
@julceslauhub review or update the password related tests, so they pass accordingly to the new password policy
|
SonarQube Quality Gate
|
caleeli
approved these changes
Nov 24, 2023
boliviacoca
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
The passwords policies are not configurable
Solution
Added validations when the users login to the app
How to Test
Add in .env the next values:
PASSWORD_POLICY_NUMBERS=TRUE
PASSWORD_POLICY_UPPERCASE=TRUE
PASSWORD_POLICY_SPECIAL=TRUE
PASSWORD_POLICY_MINIMUM_LENGTH=8
PASSWORD_POLICY_MAXIMUM_LENGTH=12
PASSWORD_POLICY_LOGIN_ATTEMPTS=5
And validate when user login to the app
Related Tickets & Packages
https://processmaker.atlassian.net/browse/FOUR-11415
Code Review Checklist