Skip to content

Conversation

@philgagnon12
Copy link

Changed how the form data is fetched

(cake2.0)$this->controller->request->data, instead of : (cake1.3)$this->controller->params['form']

Also added another mandatory component method :

function beforeRedirect(&$controller, $url, $status=null, $exit=true) { }

ProLoser pushed a commit that referenced this pull request Feb 21, 2012
@ProLoser ProLoser merged commit 0f595c2 into ProLoser:master Feb 21, 2012
@ProLoser
Copy link
Owner

You should consider pulling from me as I merged in some fixes from other branches. Are you sure you don't need to return anything in the stubbed out methods?

@philgagnon12
Copy link
Author

Hi , sorry , I am a total newb when it comes down to git :s or subversion , so i wouldn't know how to pull from you ....

My bad , I accidently got mixed up with Cake 1.3 Docs where component extends object instead of extending Component(Cake2.0) .. which is why i had to re declare those callbacks ...

Ill will update my fork right away .

... class WizardComponent extends Component {

function initialize($controller, $settings = array()) {
$this->controller = $controller;
....
}
instead of

function initialize(&$controller, $settings = array()) {
$this->controller =& $controller;
...
}

and removed all the empty callbacks ...

Sorry for the mix up ...

I will figure out out to pull from you then send you a pull request with those changes ? :S

@ProLoser
Copy link
Owner

To pull from me do the following from within your terminal:

git remote add proloser git://github.com/ProLoser/CakePHP-Wizard.git
git pull proloser master

Whatever branch you are in when you pull is what it will be merged into, the branch you specify in the pull is which one from MY repository you are pulling FROM. The reason that matters is because I created a branch specifically for cake1.3. You don't need it though if you just want to use cake2 (as that is my master branch).

Hopefully you should not get any merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants