Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix android collections source #862

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix android collections source #862

merged 2 commits into from
Dec 6, 2023

Conversation

tuxology
Copy link
Contributor

@tuxology tuxology commented Dec 6, 2023

  • fixes android collections so we can view in UI
  • sourceId is needed to be added as "tags" in android rules
  • this is needed to link collections to sources
  • also group and dedup collections

 * sourceId is needed to be added as "tags" in android rules
 * this is needed to link collections to sources
 * also group and dedup collections
tuxology added a commit to Privado-Inc/privado that referenced this pull request Dec 6, 2023
tuxology added a commit to Privado-Inc/privado that referenced this pull request Dec 6, 2023
@khemrajrathore
Copy link
Member

Merge this after Privado-Inc/privado#367 gets merged

Copy link
Member

@khemrajrathore khemrajrathore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ojaswa1942 pushed a commit to Privado-Inc/privado that referenced this pull request Dec 6, 2023
* add tags to link source to collections

Required for: Privado-Inc/privado-core#862

* remove rule

---------

Co-authored-by: Pandurang Patil <pandurang.patil@gmail.com>
Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>
@ojaswa1942 ojaswa1942 merged commit cc12c3f into dev Dec 6, 2023
10 checks passed
ojaswa1942 added a commit that referenced this pull request Dec 7, 2023
fix android collections source (#862)
khemrajrathore added a commit to Privado-Inc/privado that referenced this pull request Dec 18, 2023
* Python GA support

* updated mac address rule (#225)

* updated mac address rule

* removed workforce dir

---------

Co-authored-by: “Hitesh <hitesh.bedre@privado.com>

* Added rules for third party sdks in the db (#266)

* add - cookie as sink

* add - merged cookie rules

* Remove redundant ruby sdk rules

* Ruby/third party sdk secondary (#269)

* Added rules for third party sdks in the db

* added some more third parties

* refactor rules

* Handling of rule to select element split over multiple lines (#270)

* Handling of rule to select element split over multiple lines

If the tag is split into multiple lines then the existing regex was
failing to detect the element. Like the below code sample.
Handled respective use case along with the addition of corresponding
unit test

```
<ComplexInputField
                    name={FIELDS.SURNAME}
                    label={messages.surName.placeholder}
                    value={values?.surname}
                    error={errors.surname}
                  />
```

* rule fix

* Update README.md (#272)

* Js sdk fixes (#274)

* Python GA support

* updated mac address rule (#225)

* updated mac address rule

* removed workforce dir

---------

Co-authored-by: “Hitesh <hitesh.bedre@privado.com>

* Fix the sdk rules for javascript

* Update the okta rule

* Remove unwanted rules

---------

Co-authored-by: hiteshbedre <32206192+hiteshbedre@users.noreply.github.com>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>
Co-authored-by: “Hitesh <hitesh.bedre@privado.com>
Co-authored-by: Pandurang Patil <pandurang.patil@gmail.com>

* Ruby http libraries (#278)

* Support for Ruby HTTP client rules

* Update the apiHttpLibraries rule for ruby

* Update personal_characteristics.yaml

* Update biometric_data.yaml

* Ruby SDK + JS Fixes (#282)

* Support for Ruby HTTP client rules

* Update the apiHttpLibraries rule for ruby

* Additional ruby sdk + minor JS fixes

* Minor corrections in rules

* Fix the typo in fetchapi

* JS Fixes (#283)

* Ruby http libraries (#278)

* Support for Ruby HTTP client rules

* Update the apiHttpLibraries rule for ruby

* Update personal_characteristics.yaml

* Ruby SDK + JS Fixes (#282)

* Support for Ruby HTTP client rules

* Update the apiHttpLibraries rule for ruby

* Additional ruby sdk + minor JS fixes

* Minor corrections in rules

* Fix the typo in fetchapi

---------

Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>

* Sources/click stream ddhq (#284)

* add datadog initialization params which default track click behaviour

* Add IndexedDB storage rule

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>

* vehicle registration rule

* Laundarkly fix (#287)

* Remove useFlags method from launchdarkly sdk

* Minor correction in laundarkly fix

* JS sdk fixes -1

* Fix code-review comment

* Dev (#285)

* Sources/click stream ddhq (#284)

* add datadog initialization params which default track click behaviour

* Add IndexedDB storage rule

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>

* vehicle registration rule

* Laundarkly fix (#287)

* Remove useFlags method from launchdarkly sdk

* Minor correction in laundarkly fix

* JS sdk fixes -1

* Fix code-review comment

---------

Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>

* updated leakage rule (#292)

* Ruby august release (#294)

* change - wechat rule

* fix - tencent cloud

* add - thirdParty api

* add - new rules in ruby

* add more rules

* Python: Stripe Rule (#297)

* Python: Stripe Rule (#298)

* Add Graphql rules as API rules (#299)

* Add Graphql rules as API rules

* Add client creation baseurl detection pattern

* Add mongodb rule for models

* Add OpenAI sdk rules (#302)

* Add OpenAI sdk rules

* Fix code review comments

* Removed duplicate rule (#303)

* Removed duplicate rule (#303) (#304)

* Update the LLM rules + Add Weviate DB (#306)

* Added rules for ruby third party (#295)

* Added rules for ruby third party

* removed already existing rule

* added hellosign rule

* code refactoring

* Update online_identifiers.yaml (#305)

* Update online_identifiers.yaml

* fix - redis rule in ruby

* new rules

---------

Co-authored-by: root <root@ip-172-31-4-154.eu-west-1.compute.internal>

* [goSrc2cpg] - Added Golang storage rule (#309)

* Added golang storage rule

* golang rule change

* Go: leakage sink (#310)

* leakage sink

* added leakage rules based on package name

---------

Co-authored-by: “Hitesh <hitesh.bedre@privado.com>

* default config for zeromq sockets (#311)

* Dev (#285)

* Sources/click stream ddhq (#284)

* add datadog initialization params which default track click behaviour

* Add IndexedDB storage rule

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>

* vehicle registration rule

* Laundarkly fix (#287)

* Remove useFlags method from launchdarkly sdk

* Minor correction in laundarkly fix

* JS sdk fixes -1

* Fix code-review comment

---------

Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>

* Python: Stripe Rule (#298)

* Removed duplicate rule (#303) (#304)

* default config for zeromq sockets

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>
Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>
Co-authored-by: hiteshbedre <32206192+hiteshbedre@users.noreply.github.com>

* Golang storage rule (#312)

* Added golang storage rule

* golang rule change

* fix go rule

* fix amazons3 domains rule

* Added rule for go sqlx

* Updated s3 rules

---------

Co-authored-by: Ankit Kumar <ankit.kumar@privado.ai>

* added zerolog rules for logs

* changed redis rules

* Remove SQL Alchmey rule  for python (#315)

* Go: Storage Rules (#317)

* go: database rule

* go: storage support

* go: divided into read and readandwrite rules

* divided rule into two

* go: corrected weaviate rule

---------

Co-authored-by: “Hitesh <hitesh.bedre@privado.com>

* Golang storage rules (#318)

* storage rules

* arangodb go rule fix

* added storage rules

* parallel processing for comparisom report (#321)

* parallel processing for comparison report (#324)

* Parallel comparison report (#326)

* parallel processing for comparison report

* change standalone ref to parallel-test

* change zip command to get only one folder

* change ref to main

* Delete zamaon sdk (#328)

* added go exclusion rule (#329)

* vertx.io is not a third party, its a toolkit

* Update Account Password.

* Go GORM rules (#338)

* go: API Tagger (#331)

* go: API Tagger

* added internal api rule

* added do method

---------

Co-authored-by: “Hitesh <hitesh.bedre@privado.com>

* [gosrc2cpg] - Added third party rules (#335)

* Added go third party rules

* Added more GO third parties

* Added more rules

* added more rules

* go rule fix

* go third party rule fix

* go third party backslash fix

* go third parties rule fix

* [gosrc2cpg] - storage framework rules (#340)

* added gorm rule

* fix gorm rule

* added more storage rules

* Added more framework rules

* dummy-commit

* Update national_identification_numbers.yaml (#334)

* Python/3p/cherrypy (#308)

* Dev (#285)

* Sources/click stream ddhq (#284)

* add datadog initialization params which default track click behaviour

* Add IndexedDB storage rule

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>

* vehicle registration rule

* Laundarkly fix (#287)

* Remove useFlags method from launchdarkly sdk

* Minor correction in laundarkly fix

* JS sdk fixes -1

* Fix code-review comment

---------

Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>

* Python: Stripe Rule (#298)

* Removed duplicate rule (#303) (#304)

* Delete rules/sinks/third_parties/sdk/cherrypy/python.yaml

cherrypy is a framework not a thirdparty

---------

Co-authored-by: Datta Mundada <dbmundada333@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>
Co-authored-by: hiteshbedre <32206192+hiteshbedre@users.noreply.github.com>

* change slack action to upload file (#342)

* Kotlin poc (#344)

* kotlin logging rules

* api rules

* add - kotlin rule

* modified mongo rule

* add - more rules

* Added go comparison report support (#345)

* fix path in comparison results (#346)

* add - regex for exclusion templates in kotlin (#348)

* add - regex for exclusion templates in kotlin

* update regex

* Revert "update regex"

This reverts commit c7b9507.

* Google map and google play rule (#349)

* kotlin logging rules

* api rules

* add - kotlin rule

* modified mongo rule

* add - more rules

* add - more google rules

* lng  matches with short for language (#350)

* add rule for authy (#351)

* spring java patch collection (#353)

* go exclusion rule fix (#354)

* Revert "go exclusion rule fix (#354)"

This reverts commit 69b9f9b.

* add datadog java sdks

source : https://docs.datadoghq.com/developers/community/libraries/

* add android collection rules (#356)

* added go third party rules (#358)

* Go additional rule (#361)

* added go third party rules

* go temporal rule

* Go third party rule (#363)

* added go third party rule

* go slack rule added

* go github rule added (#365)

* add tags to link source to collections (#367)

* add tags to link source to collections

Required for: Privado-Inc/privado-core#862

* remove rule

---------

Co-authored-by: Pandurang Patil <pandurang.patil@gmail.com>
Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>

* refine cookie storage rule (#369)

* refine cookie storage rule

* refine cookie storage rule

---------

Co-authored-by: Hitesh Mahajan <hitesh.mahajan@privado.ai>

* Go APIHttp Libraries rule (#371)

* added go apihttp libraries

* go apihttp improvement

* Add few more android rules (#372)

* add more android rules

* education rules

* Update any.yaml

* fix

---------

Co-authored-by: Pandurang Patil <pandurang.patil@gmail.com>
Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: KhemrajSingh Rathore <khemraj.rathore@privado.ai>

* fix java google pubsub

---------

Co-authored-by: hiteshbedre <32206192+hiteshbedre@users.noreply.github.com>
Co-authored-by: “Hitesh <hitesh.bedre@privado.com>
Co-authored-by: Pandurang Patil <pandurang.patil@gmail.com>
Co-authored-by: Karan Batavia <118820668+karan-batavia@users.noreply.github.com>
Co-authored-by: Dattaprasad Mundada <dbmundada333@gmail.com>
Co-authored-by: Hitesh Mahajan <hiteshvm1998@gmail.com>
Co-authored-by: Hitesh Mahajan <hitesh@Hiteshs-MacBook-Pro.local>
Co-authored-by: Ankit Kumar <118803988+ankit-privado@users.noreply.github.com>
Co-authored-by: root <root@ip-172-31-4-154.eu-west-1.compute.internal>
Co-authored-by: Suchakra Sharma <suchakra@privado.ai>
Co-authored-by: Ankit Kumar <ankit.kumar@privado.ai>
Co-authored-by: Hitesh Mahajan <hitesh.mahajan@privado.ai>
@khemrajrathore khemrajrathore deleted the collection-sources-fix branch March 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants