Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pm-toggle dialog keep reopening after closing using "Enter" key when "X" is focused #67

Closed
Manvel opened this issue Dec 24, 2019 · 2 comments
Closed

pm-toggle dialog keep reopening after closing using "Enter" key when "X" is focused #67

Manvel opened this issue Dec 24, 2019 · 2 comments

Comments

@Manvel
Copy link
Member

Manvel commented Dec 24, 2019

No description provided.

@Manvel
Copy link
Member Author

Manvel commented Jan 1, 2020

The problem is that keyup event that is being triggered on X button is being fired also on the element to which the focus is being moved - the #label element.

@Manvel
Copy link
Member Author

Manvel commented Jan 1, 2020 •
edited
Loading

Having more closer look seems like the issue is, because instead of keyup event click event is being fired on button.

Manvel added a commit that referenced this issue Jan 2, 2020
@Manvel
#67 - use keydown instead of keyup event on pm-toggle label
03d1af3
@Manvel Manvel closed this as completed Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Manvel