1.21: Update test code chat handling #1441
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add null checks for senderName field in player_chat packets - Handle empty NBT tags (type: end) in 1.21+ where networkName can be null - Fixes crash when accessing properties on null senderName
HenkjanvDiermen
changed the title
extremeheat
changed the title
extremeheat
reviewed
Jan 26, 2026
| // In 1.21+, senderName can be null when networkName is empty (NBT type: end) | ||
| if (data.senderName) { | ||
| const sender = JSON.parse(data.senderName) | ||
| if (sender) { // ADD THIS CHECK |
Member
There was a problem hiding this comment.
Please make sure to remove LLM generated lines like this.
Our tests are already passing as is, so I'm not sure what purpose of this code is. It might be possible for senderName to be null, however the vanilla client should send it as the tests are currently passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Minecraft 1.21.9 (protocol version 773) to node-minecraft-protocol.
Changes
senderNamecan be null whennetworkNameis an empty NBT tagProblem Solved
In Minecraft 1.21+, the
networkNamefield in player_chat packets can be an empty NBT tag ({type: "end"}). When this happens,processMessage(networkName)returnsnull, causing tests to crash when trying to access properties on the null value.Testing
✅ All 6262 tests passing
✅ Chat test specifically fixed for 1.21.9
Dependencies
This PR includes changes to node-minecraft-protocol. Corresponding changes are needed in PrismarineJS/minecraft-data:
name,prefix,suffixfields optional in packet_teams protocol definitionRelated
Part of the 1.21.9 support effort for the PrismarineJS ecosystem.