-
Notifications
You must be signed in to change notification settings - Fork 23
Description
@rom1504, happy holidays!
I've noticed today that package.json files in the examples folder require as dependency an ancient version of minecraft-protocol (^0.20.3). The way it is now, running npm install from each example folder will result in error.
Instead, in client_forge folder, the package.json file should require just minecraft-protocol-forge:
"dependencies": {
"minecraft-protocol-forge": "file:../../"
},
(It also needs minecraft-protocol and protodef, but these packages are already required by minecraft-protocol-forge).
In mineflayer_forge folder:
"dependencies": {
"minecraft-protocol-forge": "file:../../",
"mineflayer": "^4.17.0",
"mineflayer-pathfinder": "^2.4.5"
},
And in mineflayer_forge_simplelogin folder:
"dependencies": {
"minecraft-protocol-forge": "file:../../",
"mineflayer": "^4.17.0",
"mineflayer-pathfinder": "^2.4.5",
"crypto-js": "^4.2.0"
},
Now examples work after I run npm install in the root folder of the repo, and then again in the example folder I want to use. I'd open PR if needed, but I hardly know anything about npm and package.json, so wanted to ask your opinion before doing anything.