Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle file activation and init boostraping #943

Merged
merged 1 commit into from
Feb 19, 2017

Conversation

mfe-
Copy link
Contributor

@mfe- mfe- commented Feb 12, 2017

Opening a prism uwp app by the file type association, results in a hanging app (You only see the splash screen, no view will be loaded)

Steps to reproduce:

  1. Open Package.appxmanifest
  2. Go to Declarations and add File Type association
  3. Association for example a jpg file
  4. call contextmenue in windows explorer on a jpg file. select open with. select your app.
  5. Only spash screen will be displayed.

This is behavior is caused by not calling InitializeShell.

Changes proposed in this pull request:

Override OnFileActivated and call OnActivated to initiate the "bootstrapping" process of prism.

@dnfclas
Copy link

dnfclas commented Feb 12, 2017

Hi @mfe-, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Feb 12, 2017

@mfe-, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[11]: https://www.nuget.org/packages/Prism.Ninject.Forms/
[12]: https://www.nuget.org/packages/Prism.Autofac.Forms/
[13]: https://www.nuget.org/packages/Prism.DryIoc.Forms/
#NuGet Packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What triggered the change of this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, I dont know. I modified the PrismApplication.cs and did a rebuild.

@bartlannoeye bartlannoeye merged commit 520b034 into PrismLibrary:master Feb 19, 2017
@lock
Copy link

lock bot commented Jan 29, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants