Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use instance of IContainerProvider to resolve dependencies #2847

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

dansiegel
Copy link
Member

Description of Change

This updates the ContainerResolutionException to take the IContainerProvider as an argument. This ensures that when GetErrors is called it will make use of the current scope rather than attempting to use the root container.

Bugs Fixed

  • ContainerResolutionException.GetErrors uses root container

API Changes

  • n/a

Behavioral Changes

ContainerResolutionException will now use the scoped instance of the ContainerProvider that was used when the exception was thrown rather than falling back to the Root.

@dansiegel dansiegel requested a review from brianlagunas as a code owner March 21, 2023 23:37
@dansiegel dansiegel merged commit 294e24b into master Mar 22, 2023
@dansiegel dansiegel deleted the scope-container-resolution branch March 22, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant