Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Enhancements #1669

Merged
merged 2 commits into from
Jan 23, 2019
Merged

API Enhancements #1669

merged 2 commits into from
Jan 23, 2019

Conversation

dansiegel
Copy link
Member

Description of Change

The included changes provide a little syntactic sugar to the existing APIs

Bugs Fixed

n/a

API Changes

ActionSheetButton - eliminate the requirement to pass in either an Action or Command for Cancel/Destroy buttons where the intent may simply be to dismiss the dialog.

Added:

  • static IActionSheetButton CreateCancelButton(string)
  • static IActionSheetButton CreateDestroyButton(string)

INavigationService - now that we're making use of Tuples across the board with IContainerProvider, adding extension methods to allow simply passing in Tuples rather than having to explicitly create new NavigationParameters. Added for both Prism.Windows and Prism.Forms

  • Task NavigateAsync(string, params (string, object)[])
  • Task NavigateAsync(Uri, params (string, object)[])
  • Task GoBackAsync(params (string, object)[])

Behavioral Changes

none

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas brianlagunas merged commit e7cecd0 into master Jan 23, 2019
@brianlagunas brianlagunas deleted the api-enhancements branch January 23, 2019 02:57
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants