Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xaml nav #1577

Merged
merged 5 commits into from
Oct 15, 2018
Merged

Xaml nav #1577

merged 5 commits into from
Oct 15, 2018

Conversation

dansiegel
Copy link
Member

Description of Change

Refactors the lookup logic for the Xaml Navigation Extension to delay the lookup of the Target object and parent Page. Adds unit tests and exception logging.

Bugs Fixed

API Changes

API is unchanged.

Behavioral Changes

  • XAML Navigation Extensions no longer return false if the parent Page cannot be found.
  • The SourcePage is only set in the event it has not been specified by the developer
  • In the event that the Parent Page is set as the Master of a MasterDetailPage, the SourcePage will be set to the MasterDetailPage
  • A new virtual method has been added to Log exceptions. By default this uses the Xamarin.Forms Log which is the same mechanism used for Binding and other XF XAML Extensions

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard

@brianlagunas brianlagunas merged commit 9d05095 into master Oct 15, 2018
@brianlagunas brianlagunas deleted the xaml-nav branch October 15, 2018 15:35
@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XAML NavigateTo on Partial Views error
2 participants