Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more x:DataType to DataTemplates #111

Merged
merged 1 commit into from
Oct 12, 2020
Merged

add more x:DataType to DataTemplates #111

merged 1 commit into from
Oct 12, 2020

Conversation

jmegner
Copy link
Contributor

@jmegner jmegner commented Sep 9, 2020

No description provided.

@jmegner jmegner requested a review from dansiegel as a code owner September 9, 2020 11:21
@jmegner
Copy link
Contributor Author

jmegner commented Oct 11, 2020

Is there anything more needed for this pull request to be satisfactory?

@brianlagunas
Copy link
Member

This PR has no issues associated with it, and no description describing the purpose of this PR. What exactly are you fixing?

@jmegner
Copy link
Contributor Author

jmegner commented Oct 12, 2020

Sorry, this pull request was right after the very similar accepted pull request 109. As the commit says: add more x:DataType to DataTemplates to get rid of false-alarm messages about binding failures.

A lot of the sample projects will give runtime error messages about binding failures in UWP, but the binding are actually correct. Adding x:DataType to DataTemplates solves this problem.

@brianlagunas brianlagunas merged commit 7a9b04a into PrismLibrary:master Oct 12, 2020
@brianlagunas
Copy link
Member

Thanks for the context, and for the PR

@jmegner
Copy link
Contributor Author

jmegner commented Oct 12, 2020

I hope I can contribute even more in the future. Thanks for Prism, and thanks for all your (@brianlagunas and @dansiegel) help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel Awaiting requested review from dansiegel dansiegel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmegner @brianlagunas