Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Added with keyword & improved record support #2993

Merged
merged 1 commit into from
Jul 15, 2021
Merged

C#: Added with keyword & improved record support #2993

merged 1 commit into from
Jul 15, 2021

Conversation

RunDevelopment
Copy link
Member

As promised in #2991, here are some improvements for C# records.

  • Added support for the with keyword.
  • Type lists for records (inheritance) are now supported.
  • Added support for the new() generic constraint. I simply forgot to add it. new() was added in C# 7.3, I believe.

@github-actions
Copy link

JS File Size Changes (gzipped)

A total of 1 files have changed, with a combined diff of +69 B (+2.9%).

file master pull size diff % diff
components/prism-csharp.min.js 2.37 KB 2.44 KB +69 B +2.9%

Generated by 🚫 dangerJS against 04e9290

JaKXz
JaKXz approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@JaKXz JaKXz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't worked with C# in a few years, so take with a grain of salt, but this makes sense to me 👍🏽

@RunDevelopment RunDevelopment merged commit fdd291c into PrismJS:master Jul 15, 2021
@RunDevelopment RunDevelopment deleted the csharp-9.0-improvements branch July 15, 2021 17:42
@sync-by-unito sync-by-unito bot mentioned this pull request Sep 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaKXz JaKXz JaKXz approved these changes

Assignees
No one assigned
Labels
enhancement language-definitions needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @JaKXz