Fix author listing #259
Fix author listing #259
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the author listing issue by ensuring that both names and emails are correctly presented for package distribution. The changes add separate entries for authors with and without emails.
- Added entries for "Noah Hollmann", "Samuel Müller", and "Frank Hutter" without emails alongside their existing email entries.
- Updated the pyproject.toml to support proper author listing on PyPI and Pepi.
pyproject.toml
Outdated
| @@ -16,13 +16,16 @@ dependencies = [ | |||
| ] | |||
| requires-python = ">=3.9" | |||
| authors = [ | |||
| { name = "Noah Hollmann" }, | |||
There was a problem hiding this comment.
The author 'Noah Hollmann' is now listed twice (once with and once without an email). Consider removing the redundant entry to prevent duplicate listings in package displays.
| { name = "Noah Hollmann" }, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| { name = "Noah Hollmann", email = "noah.hollmann@charite.de" }, | ||
| { name = "Samuel Müller" }, |
There was a problem hiding this comment.
The author 'Samuel Müller' appears twice with one entry missing an email. Please remove the duplicate entry without an email to maintain consistency in author listing.
| { name = "Samuel Müller" }, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| { name = "Samuel Müller", email = "muellesa@cs.uni-freiburg.de" }, | ||
| { name = "Lennart Purucker" }, | ||
| { name = "Arjun Krishnakumar" }, | ||
| { name = "Max Körfer" }, | ||
| { name = "Shi Bin Hoo" }, | ||
| { name = "Robin Tibor Schirrmeister" }, | ||
| { name = "Frank Hutter" }, |
There was a problem hiding this comment.
The author 'Frank Hutter' is duplicated with one entry lacking an email. Remove the redundant entry without an email to ensure a single, consistent author listing.
| { name = "Frank Hutter" }, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
pyproject.toml:19
- Duplicate entry for author 'Noah Hollmann' detected; if this duplication is intentional to address listing issues, please add a clarifying comment for future maintainers, otherwise consider consolidating the entries.
{ name = "Noah Hollmann" },
pyproject.toml:21
- Duplicate entry for author 'Samuel Müller' detected; if intentional for display reasons, a clarifying comment would improve code clarity or consider consolidating the entries if not required.
{ name = "Samuel Müller" },
| { name = "Samuel Müller", email = "muellesa@cs.uni-freiburg.de" }, | ||
| { name = "Lennart Purucker" }, | ||
| { name = "Arjun Krishnakumar" }, | ||
| { name = "Max Körfer" }, | ||
| { name = "Shi Bin Hoo" }, | ||
| { name = "Robin Tibor Schirrmeister" }, | ||
| { name = "Frank Hutter" }, |
There was a problem hiding this comment.
Duplicate entry for author 'Frank Hutter' detected; if this duplication is needed for proper listing, please document the reasoning, otherwise consider merging the entries.
| { name = "Frank Hutter" }, |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Authors weren't properly listed on pypi and pepi with the emails