Skip to content

Conversation

@Jeredian
Copy link
Collaborator

@Jeredian Jeredian commented Apr 21, 2024

Description

Changes:

  • github.event.label.name was changed to github.event.issue.labels.*.name
  • new Generate token step to fix the author of bot comments
  • updated comment texts to be in the same style

Type of change

What kind of change does this PR introduce?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Translations
  • Documentation
  • Other... Please describe:

What is the current behavior?

Workflow is skipped, message can be only from default bot

What is the new behavior(if this is a feature change)?

Workflow runs, and comment will be placed from organisation's bot

How has this been tested?

Does this PR introduce a breaking change?

  • Yes
  • No

Does it closes one of the existing issues?

  • Yes
  • No

closes #35

Other information

PR Checklist:

  • The pull request opens from the issue/patch/feature/bugfix branch (right side) and not main branch!
  • The pull request title, commit messages and code are follows our guidelines: Contribution guide
  • All commits are signed-off. See How to sign-off commit
  • The code changes are commented, particularly in hard-to-understand areas

Signed-off-by: Pavel Polyakov <djeredian@gmail.com>
@printmakerlab-bot printmakerlab-bot bot added the pull request: bug Pull request with changes related to behavior that is considered incorrect label Apr 21, 2024
Signed-off-by: Pavel Polyakov <djeredian@gmail.com>
Signed-off-by: Pavel Polyakov <djeredian@gmail.com>
@Jeredian Jeredian marked this pull request as ready for review April 22, 2024 07:45
@Jeredian Jeredian requested a review from GudwinTheGreat April 22, 2024 07:45
@Jeredian Jeredian merged commit 4c42b18 into main Apr 22, 2024
@Jeredian Jeredian deleted the issue-35 branch April 22, 2024 08:55
@github-actions
Copy link

The content of this pull request will be made available as part of our next release.

@printmakerlab-bot
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@printmakerlab-bot printmakerlab-bot bot locked as resolved and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

pull request: bug Pull request with changes related to behavior that is considered incorrect status: outdated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Issue / New issue triage" workflow doesn't work

3 participants