Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devel #723

Merged
merged 7 commits into from
Mar 12, 2018
Merged

Devel #723

merged 7 commits into from
Mar 12, 2018

Conversation

KristenManning
Copy link
Contributor

No description provided.

* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* • Project
  - Delete ASSIGN everywhere except in OutputState and Keywords

* • LearningMechanism failing

* • LearningMechanism
  _validate_params:
      replaced try and except for learning_signal[PARAMS][PROJECTIONS]
      with if-else

• OutputState:
  _parse_state_specific_specs:
      refactored for VARIABLE in place of INDEX in 3-item tuple

* • LearningMechanism
  _validate_params:
      replaced try and except for learning_signal[PARAMS][PROJECTIONS]
      with if-else

• OutputState:
  _parse_state_specific_specs:
      refactored for VARIABLE in place of INDEX in 3-item tuple
  docstring revised per above

* -

* -
* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* -
* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* -

* • OutputState
  docstring revs
* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* • Mechanism
  added MechParamsDict as dict subclass

• OutputState
  _parse_variable_spec: checks that dicts passed to it are MechParamsDict
* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* • Function
  - UserDefinedFunction:
      docstring revs

* • Function
  - UserDefinedFunction:
      examines arguments of custom function to assign as params

* -

* • Function
  - UserDefinedFunction:
      - identifies modulatory params
      - works with lamda functions
      - works with position and keyworded arguments
      - passes all tests

* -

* • Component
  _get_current_execution_time:  added method

* • Component
  _get_current_execution_time:  added method

* -

* • Gating Mechanism with UDF:
  debugging OutputState function assignment

* -

* -

* -

* -

* -

* -

* -

* -

* -

* -

* • Component
  _assign_args_to_param_dicts():
      added defaults argument that also defaults to be passed
      (that override those specified as argument values in init

* • Component
  _assign_args_to_param_dicts():
      added defaults argument that also defaults to be passed
      (that override those specified as argument values in init

* -

* -

* • Function
  UserDefinedFunction: docstring examples added
Incorporate changes to LearingFunctions from old PR:
  - remove activation_function from constructors
  - docstring changes
  - other minor stuff?
* • ControlMechanism
  assign_as_controller:  fixed bug (assignment of self.allocation)

* • Function
  UserDefinedFunction:
  - fixed some bugs examples

* • Function
  UserDefinedFunction:
  - fixed some bugs examples
  - doctest is now run on examples

* -

* -

* -

* • Function
  UserDefinedFunction:
    - fixed bugs in examples
    - doctest is now run on examples

* • Function
  UserDefinedFunction:
    - fixed bugs in examples
    - doctest is now run on examples
@KristenManning KristenManning merged commit 23ef618 into master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants