tests: ensure seed change test uses new seed #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since each test uses incrementing fixed seeds from 0, using new_seed = 1 will cause it to share a seed with some other component, depending on the order in which components are created (ex: one Parameter is instantiated before or after another, resulting in different individual seeds for each). This ensures that new_seed will actually be unused in the test.
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since each test uses incrementing fixed seeds from 0, using new_seed = 1 will cause it to share a seed with some other component, depending on the order in which components are created (ex: one Parameter is instantiated before or after another, resulting in different individual seeds for each).
This ensures that new_seed will actually be unused in the test.