tests: Run all tests using --fp-precision=fp32 #2629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the fixture adds correct marks. Skip on compiled variant on fp32 since Python execution uses fp64. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Fix selection of expected results when running in Python and --fp-precision=fp32 Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
autodiff_mode includes LLVMRun and PyTorch execution mode, checking comparison to ExecutionMode.Python is false for both. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
Switch fp32 run to python3.8 to get better coverage of python versions. This should help catch compiled tests that are not correctly marked. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check fp32 results if running compiled test variant.
Use correct execution mode checks in test_optimizer_specs.
Convert identicalness PyTorch vs. LLVM test to
autodiff_modefixture.Enable the entire test suite running --fp-precision=fp32 in CI