tests/llvm/multiple_executions: Use np.testing.assert_allclose to check results #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
…ck resutls assert_allclose checks the shape of compared arrays as well as the values. Drop explicit checks for the size of the outer dimension. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
kmantel
added a commit
to kmantel/PsyNeuLink
that referenced
this pull request
Apr 14, 2023
* origin/devel: tests: remove asserts using zip loops where possible tests: replace all unaffected assert np.allclose with np.testing.assert_allclose tests: replace assert np.allclose with np.testing.assert_allclose where tolerance fails tests: test_gating_with_composition: fix allclose tests: test_log: fix allclose shape tests: test_rpy.py test_multilayer: fix allclose tests: test_reset_run_2darray: fix allclose tests: test_transfer_mech_array_var_normal_array_noise: fix allclose tests: test_single_array: fix allclose tests: test_connect_outer_composition_to_only_input_node_in_inner_comp_option2: fix allclose tests: test_AGTUtility_valid: fix allclose tests: test_target_dict_spec_single_trial_scalar_and_lists_rl: fix allclose tests: test_transfer_mech_func: fix allclose tests: test_input_specification_multiple_nested_compositions: fix allclose tests: test_input_not_provided_to_run: fix allclose tests: test_example_11: fix allclose tests: test_buffer_standalone: fix allclose tests: test_assign_value: fix allclose tests: TestRunInputSpecifications::test_2_mechanisms_input_5: fix allclose tests: test_integrator_multiple_input: fix allclose tests: tests_output_port_variable_spec_composition: fix allclose tests: test_output_ports: fix allclose tests: test_LCAMechanism_threshold: fix allclose tests: test_user_def_func_numpy: match 2d output to 2d input tests: test_linear_combination_function_in_mechanism: fix allclose tests: test_connect_compositions_with_simple_states: fix allclose tests: TestInputSpecifications test_run_2_mechanisms_reuse_input: fix allclose tests: TestRun test_run_2_mechanisms_reuse_input: fix allclose tests: TestRunInputSpecifications test_run_2_mechanisms_reuse_input: fix allclose tests: test_nested_transfer_mechanism_composition_parallel shape mismatch Fix test_ddm_mechanism TestInputPorts Fix test_reset_run_array Fix TestReduce Fix test_reset_state_integrator_mechanism Fix more execute tests. Fix more composition.run() tests. Fix test_four_level_nested_transfer_mechanism_composition_parallel Fix test_processing_mechanism_function tests: allclose changes Fix log tests tests: allclose changes Fix expected 3D outputs Fix test_run_no_inputs tests: allclose changes tests: allclose changes tests: allclose changes Fix expected results shape tests: test_nested_composition_run_trials_inputs: undo disable test parametrizations tests: allclose changes tests: test_documentation_models: reenable parametrizations github-actions: Add job running --benchmark-enable tests/AudodiffComposition: Add helper function to return the first set of learning results github-actions: Run all tests with --fp-precision=fp32 tests/Autodiff: Check for execution mode PyTorch in test_optimizer specs tests/control: FP32 should only be used in compiled tests tests/xor_training_identicalness: Convert to use autodiff_mode tests/MemoryFunction: Prefer np.testing.assert_equal to assert np.all(==) test/AutodiffComposition: Use np.testing.assert_equal instead of assert np.all(==) requirements: update beartype requirement from <0.13.0 to <0.14.0 (PrincetonUniversity#2625) requirements: update pytest requirement from <7.2.3 to <7.3.1 (PrincetonUniversity#2627) requirements: Drop grpcio-tools requirements: Add protobuf to dependency list {dev,tutorial}_requirements: Use sharp inequality for jupyter upper bound dev_requirements: Use sharp inequality of pytest-profiling upper bound requirements: Sort alphabetically requirements: Use sharp inequality for leabra-psyneulink upper bound requirements: Fix dill dependency upper bound requirements: Use sharp inequality for bear type upper bound Tentative learning branch (PrincetonUniversity#2623) tests/llvm/multiple_executions: Use np.testing.assert_allclose to check resutls (PrincetonUniversity#2621) requirements: update pandas requirement from <1.5.4 to <2.0.1 (PrincetonUniversity#2619) Add back rate validation in constructor. Add back validation I added for offset. Remove validation I added for offset. Add validate methods as kmantel suggests requirements: update pillow requirement from <9.5.0 to <9.6.0 (PrincetonUniversity#2618) Remove typecheck-decorator requirment. Fix some annotations. requirements: update networkx requirement from <3.1 to <3.2 (PrincetonUniversity#2620) Nback (PrincetonUniversity#2617) Fix/contentaddressablememory empty entry (PrincetonUniversity#2616) Fix some annotations on learning methods. Fix some issues with merge of composition. Fix type annotation on _get_port_value_labels Remove check_user_specified in places. Replace typecheck decorator with beartype Add typecheck decorator back temporarily llvm: Add human readable name to _node_wrapper instances llvm: Use WeakRefDictionary for node wrappers llvm/builder_context: Use proxy object for _node_wrapper owning composition remove redefinition of ENTROPY keyword Raise KeyError on MechanismList.__seitem__ fix some lgtm errors remove unused imports revert ci testing changes completely for now. Fix codestyle errors. Revert back to testing on Python 3.9. Fix specifcation of Python 3.10 in ci workflow Fixes for Python 3.7 Enable tests for python 3.10 in CI. Add beartype for runtime type checking. Replace typecheck import with beartype Removed all the tc.optional typecheck annotations replaced all typecheck enums with Literal Replace is_function_type with static type Replace is_pref_set with static type Replace parameter_spec with static type. Remove dead code in parameter_spec ran some regexes to replace easy type hints fix for some tests that expect runtime type checks Comment out all typecheck decorations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_allclose checks the shape of compared arrays as well as the values.
Drop explicit checks for the size of the outer dimension.