-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/show graph/cim #2280
Fix/show graph/cim #2280
Conversation
…Link into devel � Conflicts: � psyneulink/core/components/mechanisms/modulatory/control/optimizationcontrolmechanism.py
- _assign_incoming_edges(): allow input_CIM of outermost comp to render as node
- _assign_incoming_edges(): allow input_CIM of outermost comp to render as node - _assign_controller_components(): allow direct projections from nested nodes to OCM or ObjectiveMechanism when show_cim=False
add test_projections_from_nested_comp_to_ocm_or_obj_mech
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
This pull request introduces 1 alert when merging 67ccee1 into da4ecb7 - view on LGTM.com new alerts:
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):
See CI logs for the full diff. |
tests/composition/test_show_graph.py
Outdated
# The bug may be the same one as in eb61303808ad2a5ba46fdd18d0e583283397915c | ||
raise(AssertionError,"FAILURE TO REPLICATE BUGGY SHOW_GRAPH OUTPUT -- SEE COMMENT IN TEST") | ||
else: | ||
raise(AssertionError) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thiscan be just:
raise
to forward the existing exception/assertion instead of creating a new one
This pull request introduces 1 alert when merging 4c3ff97 into 544c1ec - view on LGTM.com new alerts:
|
• showgraph.py:
- _assign_incoming_edges(): allow input_CIM of outermost comp to render as node
- _assign_controller_components():
allow direct projections from nested nodes to OCM or ObjectiveMechanism when show_cim=False
• test_show_graph.py:
add test_projections_from_nested_comp_to_ocm_or_obj_mech