Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IntFlag for cost functions #2133

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Use IntFlag for cost functions #2133

merged 2 commits into from
Oct 1, 2021

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented Oct 1, 2021

Add test.

@jvesely
functions/TransferWithCosts: Convert CostFunctions to IntFlag instead…
c5b859b 
… if IntEnum

Bitwise combination of flags is still a flag.

Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
@jvesely
tests/control: Add simple test for all possible cost options
9545538 
Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
@jvesely jvesely requested review from jdcpni and kmantel October 1, 2021 15:30
kmantel
kmantel approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@kmantel kmantel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, I think I remember an annoyance from combining these despite not being flags

@jvesely jvesely merged commit e20a163 into PrincetonUniversity:devel Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmantel kmantel kmantel approved these changes

@jdcpni jdcpni Awaiting requested review from jdcpni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvesely @kmantel