Add FunctionParameter and SharedParameter subclasses #1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts and fixes 1 when merging 51db48d into dce7a84 - view on LGTM.com new alerts:
fixed alerts:
|
- serve as a reference to a Parameter on one of the Component's attributes or other Parameters - values are shared between target Parameter and SharedParameter - when included in constructor, automatically passed on instantiation to the relevant secondary Function ControlSignal: make several parameters FunctionParameters - needed to be included in this commit due to validation in test_control_signal_intensity_cost_function
kmantel
force-pushed
the
feat/parameters/shared-parameters
branch
from
51db48d
to
9b68fb6
Compare
|
This pull request introduces 1 alert and fixes 1 when merging 9b68fb6 into dce7a84 - view on LGTM.com new alerts:
fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parameters: add FunctionParameter and SharedParameter subclasses
other Parameters
relevant secondary Functions