ci/ga: Remove Python3.7 CI jobs

Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
PrincetonUniversity · Nov 13, 2024 · 4cfbf4e · 4cfbf4e
1 parent 30c9037
commit 4cfbf4e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 30 deletions.
diff --git a/.github/workflows/pnl-ci-docs.yml b/.github/workflows/pnl-ci-docs.yml
@@ -21,16 +21,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12']
+        python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
         os: [ubuntu-latest, macos-latest, windows-latest]
         pnl-version: ${{ (github.event_name == 'push') && fromJSON('["head"]') || fromJSON('["head", "base"]') }}
         exclude:
           - os: macos-latest
             pnl-version: 'base'
           - os: windows-latest
             pnl-version: 'base'
-          - python-version: '3.7'
-            pnl-version: 'base'
           - python-version: '3.8'
             pnl-version: 'base'
           - python-version: '3.9'
@@ -40,14 +38,6 @@ jobs:
           - python-version: '3.12'
             pnl-version: 'base'
 
-            # Python 3.7 x64 on macos-14 (arm64) images is broken [0]
-            # and arm64 version is not available [1].
-            # Restrict python 3.7 macos runs to macos-13
-            # [0] https://github.com/actions/setup-python/issues/855
-            # [1] https://github.com/actions/setup-python/issues/856
-          - python-version: '3.7'
-            os: macos-latest
-
     outputs:
       on_master: ${{ steps.on_master.outputs.on-branch }}
 
@@ -80,9 +70,7 @@ jobs:
     - name: Set up Python ${{ matrix.python-version }}
       uses: actions/setup-python@v5
       with:
-        # Block python3.7.17 on macos. see:
-        # https://github.com/actions/setup-python/issues/682
-        python-version: ${{ (matrix.os == 'macos-latest' && matrix.python-version == '3.7') && '3.7.16' || matrix.python-version }}
+        python-version: ${{ matrix.python-version }}
 
     - name: Get pip cache location
       shell: bash

diff --git a/.github/workflows/pnl-ci.yml b/.github/workflows/pnl-ci.yml
@@ -33,7 +33,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ['3.7', '3.11', '3.12']
+        python-version: ['3.8', '3.11', '3.12']
         python-architecture: ['x64']
         extra-args: ['']
         os: [ubuntu, macos, windows]
@@ -51,7 +51,7 @@ jobs:
             extra-args: '--forked -m "not llvm"'
 
           # add 32-bit build on windows
-          - python-version: '3.8'
+          - python-version: '3.9'
             python-architecture: 'x86'
             os: windows
 
@@ -70,22 +70,18 @@ jobs:
             # https://github.com/ionelmc/pytest-benchmark/issues/243
             extra-args: '-m benchmark --benchmark-enable --benchmark-only --benchmark-min-rounds=2 --benchmark-max-time=0.001 --benchmark-warmup=off -n0 --dist=no'
 
-          # add python 3.7 with deps restricted to min supported version
-          - python-version: '3.7'
-            python-architecture: 'x64'
-            os: ubuntu
-            version-restrict: 'min'
-
-          # add python 3.8 build on macos since 3.7 is broken
-          # https://github.com/actions/virtual-environments/issues/4230
-          # use default python-architecture
+          # add python 3.8 with deps restricted to min supported version
+          # use default python architecture
+          # https://github.com/actions/setup-python/issues/960
           - python-version: '3.8'
             os: macos
+            version-restrict: 'min'
 
         exclude:
-          # 3.7 is broken on macos-11,
-          # https://github.com/actions/virtual-environments/issues/4230
-          - python-version: '3.7'
+          # 3.8/x64 python is broken on aarch64 macos runners
+          # https://github.com/actions/setup-python/issues/960
+          - python-version: '3.8'
+            python-architecture: 'x64'
             os: macos
 
     steps:
@@ -112,7 +108,8 @@ jobs:
       if: ${{ matrix.version-restrict == 'min' }}
       shell: bash
       run: |
-        sed -i '/^[^#]/s/>=/==/' *requirements.txt
+        # macos/bsd sed requires backup suffix argument to -i
+        sed -i=.bak -e '/^[^#]/s/>=/==/' *requirements.txt
         git config user.name "github actions"
         git config user.email "none"
         git commit -a -m "Restrict version of direct dependencies to min"

diff --git a/.github/workflows/test-release.yml b/.github/workflows/test-release.yml
@@ -69,7 +69,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: [3.7, 3.8, 3.9, '3.10', 3.11, 3.12]
+        python-version: [3.8, 3.9, '3.10', 3.11, 3.12]
         os: [ubuntu-latest, macos-latest, windows-latest]
         dist: [wheel, sdist]