Skip to content

Output Coordinates need to be Clear #10

Description

@logan-nc

It is confusing that some outputs are in jac_out and others in jac_type. To help this, with the new netcdf outputs we will a) assign a Jacobian attribute to all Fourier vectors b) make an effort to put all outputs in jac_out. The ONLY exception should be "raw" response matrices.

A persistent issue with this approach, however, is that the theta grid remains jac_type. Thus (psi,m) fourier vectors and (psi,theta) functions are not clearly related. Should we add a theta_out variable to ipec_flux_outputs.nc? Where/when should it be calculated?

A second issue with this approach is that it might obscure bugs in the raw vectors/matrices when debugging. To allow clear debugging, we can set jac_out=jac_type and use IPEC_INPUT mmin=0,mmax=0 to set lmpert=mpert,lmfac=mfac.

Activity

  1. added this to the v0.4.0 milestone on May 6, 2016
  2. self-assigned this
    on May 6, 2016
  3. logan-nc commented on Jun 16, 2016

    @logan-nc
    ContributorAuthor

    Once I merge 0.3.4 into develop I will:

    • Output xclebsch in output coordinates, making all profiles jac_out, and make jacobian a global attribute.
    • Make profile jac_out coordinates 'm_out' and 'theta_out' to make it explicitly jac_out.
    • Remove duplicated global attributes in netcdf_init
  4. logan-nc commented on Aug 11, 2016

    @logan-nc
    ContributorAuthor

    Most was done along the way. Finished by 1cef80c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions