Skip to content

Conversation

@Hihelloy-main
Copy link

Changed the plugin's base code to be folia compatible (with some small errors)

@PrimordialMoros
Copy link
Owner

While I appreciate the effort to create this pull request, ProjectKorra itself is not Folia compatible, it is not thread safe, it has global state everywhere and changing a couple schedulers won't fix that.

You have also made several questionable changes such as breaking compatibility with previous versions and platforms, adding unused utils, lowered the minimum java version from 21 to 17 etc. I can also see two decompiled classes in the utils.

If you want to update the pr, you can bump some dependencies and cleanup some of the deprecated api usage instead.

@Hihelloy-main
Copy link
Author

While I appreciate the effort to create this pull request, ProjectKorra itself is not Folia compatible, it is not thread safe, it has global state everywhere and changing a couple schedulers won't fix that.

You have also made several questionable changes such as breaking compatibility with previous versions and platforms, adding unused utils, lowered the minimum java version from 21 to 17 etc. I can also see two decompiled classes in the utils.

If you want to update the pr, you can bump some dependencies and cleanup some of the deprecated api usage instead.

This is simply a pre release but I will do that!
(ProjectKorra isn't that compatible with folia yet, but I just want to make a Hyperion version that people can use IF they're using folia)

…is used (it now goes away when you use the move again)
Re-adds spigot support (via the FoliaScheduler library). Removes support for mc 1.20.1 and lower. Strengthens Paper support. Adds extra debug messages. Adds and utilizes the PaperLib util (meant to strengthen paper/spigot/luminol/folia compatibility). Maintains Jitpack support. Downgrades the RainbowParticleEffect to use the spigot particle builder (needed for proper spigot support). Edits the ThreadUtil.
Copies but reworks ProjectKorra's ThreadUtil (now works with Hyperion's schedulers and will be used in Hyperion 1.7.5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants