fix: RubricGroup scoring_ms should be the time to score all rubrics#953
Open
pjo256 wants to merge 2 commits intoPrimeIntellect-ai:mainfrom
Open
fix: RubricGroup scoring_ms should be the time to score all rubrics#953pjo256 wants to merge 2 commits intoPrimeIntellect-ai:mainfrom
pjo256 wants to merge 2 commits intoPrimeIntellect-ai:mainfrom
Conversation
Signed-off-by: Philip Ottesen <phiott256@gmail.com>
Signed-off-by: Philip Ottesen <phiott256@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Measure total scoring time once at the
RubricGrouplevel.scoring_mswas previously the last rubric'sscoring_msin aRubricGroup.Fixes #952.
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Low Risk
Low risk: isolated change to timing bookkeeping in
RubricGroup, plus tests validatingscoring_ms/total_msconsistency.Overview
Fixes
RubricGrouptiming soscoring_msreflects the total time spent scoring across all rubrics (rather than whatever the last rubric wrote).score_rolloutandscore_groupnow measure wall-clock time once at the group level, restore each state’s originaltimingbetween rubric evaluations, and then updatescoring_msand incrementtotal_msafter aggregation.Adds async tests asserting
generation_ms + scoring_ms == total_msfor bothscore_rolloutandscore_group.Written by Cursor Bugbot for commit 67c3e20. This will update automatically on new commits. Configure here.