fix: Resolve TOML config field placement error for prime-rl (#607)#934
Open
gspeter-max wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Open
fix: Resolve TOML config field placement error for prime-rl (#607)#934gspeter-max wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
gspeter-max wants to merge 1 commit intoPrimeIntellect-ai:mainfrom
Conversation
ROOT CAUSE: The config file had mask_truncated_completions and zero_truncated_completions nested under the [orchestrator] section, but the prime-rl package's RLConfig Pydantic model expects these fields at the top level of the TOML config. This caused Pydantic validation errors when running: uv run prime-rl @ configs/prime-rl/wiki-search.toml Error: "Extra inputs are not permitted" for orchestrator.mask_truncated_completions and orchestrator.zero_truncated_completions CHANGES: - Moved mask_truncated_completions from [orchestrator] to top level (line 6) - Moved zero_truncated_completions from [orchestrator] to top level (line 7) - These fields now appear after max_async_level and before the [model] section IMPACT: - Fixes Pydantic validation error when running prime-rl with this config - Aligns config structure with prime-rl package's RLConfig dataclass expectations - Enables users to run the documented example command successfully TECHNICAL NOTES: - The prime-rl package (external repo: PrimeIntellect-ai/prime-rl) defines RLConfig as a dataclass with these fields at the top level - The [orchestrator] section in the TOML maps to a nested OrchestratorConfig object, which does not include these two boolean fields - Other configs in configs/rl/ already use the correct structure FILES MODIFIED: - configs/local/prime-rl/wiki-search.toml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #607 - Resolves Pydantic validation error when running
uv run prime-rl @ configs/prime-rl/wiki-search.tomlProblem
When running the prime-rl trainer with the wiki-search config, users encountered:
The config file had
mask_truncated_completionsandzero_truncated_completionsnested under the[orchestrator]section, but the prime-rl package'sRLConfigexpects these fields at the top level of the TOML config.Solution
Moved the two fields from the
[orchestrator]section to the top level ofconfigs/local/prime-rl/wiki-search.toml, aligning with the prime-rl package's RLConfig dataclass structure.Changes
configs/local/prime-rl/wiki-search.tomlmask_truncated_completionsandzero_truncated_completionsfrom[orchestrator]section to top levelVerification
Test Plan
After this fix, users can successfully run:
The config structure now matches the prime-rl package's RLConfig expectations.
🤖 Generated with Claude Code
Note
Low Risk
Config-only change that just rehomes two fields; low risk aside from potential behavior differences if another loader previously relied on the old nesting.
Overview
Fixes a config schema/validation issue in
configs/local/prime-rl/wiki-search.tomlby relocatingmask_truncated_completionsandzero_truncated_completionsfrom the[orchestrator]table to the top level so they match the expectedRLConfigshape.Written by Cursor Bugbot for commit 588020c. This will update automatically on new commits. Configure here.