Skip to content

Comments

Clarify agent skill handling#886

Merged
willccbb merged 1 commit intomainfrom
codex/add-postsetup-call-to-action
Feb 10, 2026
Merged

Clarify agent skill handling#886
willccbb merged 1 commit intomainfrom
codex/add-postsetup-call-to-action

Conversation

@willccbb
Copy link
Member

@willccbb willccbb commented Feb 10, 2026

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test improvement

Testing

  • All existing tests pass when running uv run pytest locally.
  • New tests have been added to cover the changes

Checklist

  • My code follows the style guidelines of this project as outlined in AGENTS.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Additional Notes


Note

Medium Risk
Moderate risk because it changes prime lab setup behavior (new prompts/flags, filesystem symlinks/copies, and metadata writes) and adds output formatting that could affect automation or existing workflows.

Overview
Updates the Lab setup flow to scaffold coding-agent skill directories from .prime/skills (via symlink when possible, with per-agent root and name mapping) and adds --agents/--no-interactive options plus an interactive prompt to choose agents.

prime lab setup now persists user choices to .prime/lab.json and prints a new Rich “get started” call-to-action panel with quick commands; tests were expanded to cover skill dir preparation, output text, and metadata persistence. Documentation/usage was aligned by dropping the prime-rl @ CLI placeholder and clarifying Hosted Training vs self-managed prime-rl, plus adding synthetic-data guidance to the create-environment skill.

Written by Cursor Bugbot for commit 24f0288. This will update automatically on new commits. Configure here.

@willccbb willccbb merged commit b5df258 into main Feb 10, 2026
6 checks passed
@willccbb willccbb deleted the codex/add-postsetup-call-to-action branch February 10, 2026 07:23
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

primary_agent=primary_agent,
selected_agents=selected_agents,
use_multiple_agents=use_multiple_agents,
)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workspace structure docs missing new agent directories

Low Severity

prime lab setup now creates additional workspace artifacts — .codex/skills/ (or equivalent per-agent directories) and .prime/lab.json — via _prepare_agent_skill_dirs and _sync_lab_metadata. The workspace structure diagram in docs/overview.md still only shows .prime/skills/ under .prime/ and does not mention the new agent skill directories or metadata file. Per the project rule, changes to core user-facing functionality described in docs/ need corresponding documentation updates.

Fix in Cursor Fix in Web

Triggered by project rule: BugBot Instructions

monkeypatch.setattr(setup, "download_configs", lambda *_: None)
monkeypatch.setattr(setup, "sync_prime_skills", lambda: None)

setup.run_setup(skip_install=True, skip_agents_md=True)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests hang in interactive terminals without guarding prompts

Medium Severity

Several run_setup calls in tests omit no_interactive=True, while the new _resolve_setup_agents checks sys.stdin.isatty() and calls input() when it returns True. Running pytest from an interactive terminal causes these tests to block waiting for user input. The metadata tests correctly pass no_interactive=True, but test_run_setup_prints_post_setup_call_to_action and test_run_setup_prints_prime_rl_post_setup_call_to_action do not.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant