Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Replace hardcoded index access on marker_paths list with direct by-name checks for each workspace root marker. This removes the WORKSPACE_ROOT_MARKERS tuple (only used in _find_workspace_root) and checks pyproject.toml, verifiers/, and environments/ directly with their correct is_file()/is_dir() predicates. The previous approach was tightly coupled to tuple ordering - reordering or modifying WORKSPACE_ROOT_MARKERS would silently break the file-vs-directory type checks. Co-authored-by: will brown <willccbb@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
…ule_command The build_module_command method was only normalizing path arguments for install_module and eval_module. This caused relative paths like ./environments to not be resolved correctly for gepa, build, and init commands when invoked through the prime CLI. - gepa_module uses --env-dir-path/-p (same pattern as eval_module) - build_module uses --path/-p (same pattern as install_module) - init_module uses --path/-p (same pattern as install_module) Added tests for all three newly covered modules. Co-authored-by: will brown <willccbb@users.noreply.github.com>
Co-authored-by: will brown <willccbb@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Changes command construction and python interpreter selection based on workspace discovery; may affect how
prime-cliruns modules in different directory layouts and virtualenv setups.Overview
Improves workspace detection for the Prime CLI plugin by introducing
_find_workspace_root()(requirespyproject.toml,verifiers/, andenvironments/) and preferring the workspace’s.venvwhen resolving the Python executable, even whenUV_PROJECT_ENVIRONMENTis set.Updates
PrimeCLIPlugin.build_module_command()to normalize/resolve directory arguments and to auto-inject the workspaceenvironmentsdirectory for commands that need it (adds--pathforinstall/build/init, and--env-dir-pathforeval/gepa), including rewriting relative paths to absolute ones. Adds a newtests/test_prime_plugin.pysuite covering workspace root discovery, interpreter preference, and argument normalization/injection.Written by Cursor Bugbot for commit e6040bd. This will update automatically on new commits. Configure here.