Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| timing: RolloutTiming | None | ||
| error: Error | None | ||
| usage: TokenUsage | None | ||
| usage_tracker: object |
There was a problem hiding this comment.
Missing documentation for new State usage fields
Low Severity
This PR adds new usage and usage_tracker fields to the State class, which is documented in docs/reference.md. The documentation lists State fields in tables under "Fields set during initialization" and "Fields set after scoring," but these new fields are not included. Per the review rules, PRs that modify core user-facing functionality described in docs must update the relevant documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Touches core rollout generation (
Environment.get_model_response) and output serialization, so incorrect usage parsing could affect all evaluations/saved results, but changes are additive with legacy fallbacks and test coverage.Overview
Adds state-level token usage tracking via a new
StateUsageTracker, accumulating usage directly inEnvironment.get_model_responseand exposing a read-onlystate["usage"]plusEnvironment.get_state_usage().Updates
state_to_output/states_to_outputsto prefer tracked state usage (with legacy trajectory fallback) and hardens token extraction/serialization against invalid providerusagepayloads. Evaluation output now prints average token usage, and new tests cover tracking behavior, output emission rules, and invalid usage values;verifiers.__init__TYPE_CHECKING stubs are adjusted for optionalverifiers-rlexports.Written by Cursor Bugbot for commit 455850e. This will update automatically on new commits. Configure here.