move sanitize_metadata out of save_metadata#852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves
sanitize_metadataout ofsave_metadata. The reason is that there's no reason for the function to be defined inside the other function, and that prime-rl tries to importsanitize_metadatawhich it cannot if it's nested in such a way.Type of Change
Testing
uv run pytestlocally.Checklist
Note
Low Risk
Small refactor that only changes function scope/visibility; serialization and file-writing behavior remains the same.
Overview
Moves
sanitize_metadataout ofsave_metadatainverifiers/utils/save_utils.py, making it a top-level helper that can be imported by other packages.save_metadatanow calls the extractedsanitize_metadatafunction, preserving the same metadata filtering (path_to_save,date) before writingmetadata.json.Written by Cursor Bugbot for commit 16b47ad. This will update automatically on new commits. Configure here.