RLM: Add RLMEnv sandbox hooks for safer customization#849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Custom envs (e.g., mini‑swe) previously had to fork the executor to adjust sandbox setup or worker scripts. These hooks centralize the logic in RLMEnv, reduce duplication, and keep eager startup compatible with pre‑existing filesystem roots.
Type of Change
Testing
uv run pytestlocally.Checklist
Note
Medium Risk
Changes the RLM sandbox startup lifecycle (creation, readiness waiting, and worker script generation), which could impact sandbox rollouts and error handling if hooks misbehave.
Overview
RLMEnvnow exposes override hooks to customize sandbox-backed rollouts without forking the executor:get_sandbox_request(state)for per-rollout sandbox configuration,on_sandbox_ready(state, sandbox_id)for post-create setup before the worker starts, andcustomize_worker_script(script, state)to tweak the generated worker script (applied for both local and sandbox workers).Sandbox setup now preserves pre-set
state["rlm_fs_root_remote"]/state["rlm_control_dir_remote"]viasetdefault, and captures simple sandbox readiness timing instate["sandbox_state"]. Documentation indocs/environments.mdandverifiers/envs/experimental/README.mdis updated to describe these hooks and the pre-set remote path behavior.Written by Cursor Bugbot for commit 9f14410. This will update automatically on new commits. Configure here.