Skip to content

Comments

chore: enforce ruff formatting and improve dev tooling docs#845

Merged
willccbb merged 5 commits intomainfrom
docs/ty-cpu-only-check
Feb 7, 2026
Merged

chore: enforce ruff formatting and improve dev tooling docs#845
willccbb merged 5 commits intomainfrom
docs/ty-cpu-only-check

Conversation

@mikasenghaas
Copy link
Member

@mikasenghaas mikasenghaas commented Feb 6, 2026

Summary

  • Document ruff (lint + format) and ty (type-check) commands in development docs, including CPU-only --ignore unresolved-import flag
  • Run ruff format across the codebase (11 files reformatted)
  • Add ruff format --check step to the CI style workflow so formatting is enforced in CI

Test plan

  • uv run pre-commit run ruff-format --all-files passes
  • uv run ruff format --check . passes (no unformatted files)

🤖 Generated with Claude Code


Note

Low Risk
Primarily CI/tooling and code formatting changes; functional behavior should be unchanged aside from potential edge cases from automated reformatting.

Overview
Formatting is now enforced in automation. The style GitHub Action splits Ruff into a lint step plus a new ruff format --check step so PRs fail on unformatted code.

Pre-commit is updated to run Ruff via local uv run hooks (ruff check --fix and ruff format) instead of the ruff-pre-commit repo, and docs/development.md is expanded to document separate linting, formatting, and ty check commands (including a CPU-only flag).

The remaining code changes are repo-wide Ruff formatting cleanups across multiple Python modules/tests with no intended logic changes.

Written by Cursor Bugbot for commit bc062a0. This will update automatically on new commits. Configure here.

@mikasenghaas mikasenghaas changed the title docs: add ty type-check instructions for CPU-only machines chore: enforce ruff formatting and improve dev tooling docs Feb 6, 2026
mikasenghaas and others added 5 commits February 6, 2026 19:59
On machines without GPU dependencies (torch, vllm, etc.), ty reports
unresolved-import warnings. Document the --ignore unresolved-import
flag so contributors on CPU-only setups can still run the type checker.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Run ruff format across the codebase, switch pre-commit ruff hooks
from the external ruff-pre-commit repo to local hooks using the
project venv (uv run), and add a format --check step to the CI
style workflow.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mikasenghaas mikasenghaas requested a review from willccbb February 6, 2026 18:59
@mikasenghaas mikasenghaas force-pushed the docs/ty-cpu-only-check branch from 355fdd8 to bc062a0 Compare February 6, 2026 18:59
@mikasenghaas mikasenghaas marked this pull request as ready for review February 6, 2026 19:01
@willccbb
Copy link
Member

willccbb commented Feb 6, 2026

FYI i'm gonna move the RL deps into a standalone package so we can have clean cpu dev deps

see #843

@willccbb willccbb merged commit 6cd0269 into main Feb 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants