chore: enforce ruff formatting and improve dev tooling docs#845
Merged
chore: enforce ruff formatting and improve dev tooling docs#845
Conversation
On machines without GPU dependencies (torch, vllm, etc.), ty reports unresolved-import warnings. Document the --ignore unresolved-import flag so contributors on CPU-only setups can still run the type checker. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Run ruff format across the codebase, switch pre-commit ruff hooks from the external ruff-pre-commit repo to local hooks using the project venv (uv run), and add a format --check step to the CI style workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
355fdd8 to
bc062a0
Compare
Member
|
FYI i'm gonna move the RL deps into a standalone package so we can have clean cpu dev deps see #843 |
willccbb
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--ignore unresolved-importflagruff formatacross the codebase (11 files reformatted)ruff format --checkstep to the CI style workflow so formatting is enforced in CITest plan
uv run pre-commit run ruff-format --all-filespassesuv run ruff format --check .passes (no unformatted files)🤖 Generated with Claude Code
Note
Low Risk
Primarily CI/tooling and code formatting changes; functional behavior should be unchanged aside from potential edge cases from automated reformatting.
Overview
Formatting is now enforced in automation. The style GitHub Action splits Ruff into a lint step plus a new
ruff format --checkstep so PRs fail on unformatted code.Pre-commit is updated to run Ruff via local
uv runhooks (ruff check --fixandruff format) instead of theruff-pre-commitrepo, anddocs/development.mdis expanded to document separate linting, formatting, andty checkcommands (including a CPU-only flag).The remaining code changes are repo-wide Ruff formatting cleanups across multiple Python modules/tests with no intended logic changes.
Written by Cursor Bugbot for commit bc062a0. This will update automatically on new commits. Configure here.