Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Touches core evaluation execution, endpoint resolution, and worker request/timeout behavior; misconfiguration or resolution bugs could change which endpoints receive traffic or affect long-running eval stability.
Overview
Adds multi-endpoint “client pool” support by extending
ClientConfigwithendpoint_configs/client_idxand introducingresolve_client_config(s)to select and inherit per-endpoint settings (with cycle detection).Updates eval execution to round-robin across multiple endpoints (and keep grouped-scoring rollouts for the same example on a single endpoint), while ensuring locally created clients are closed on success, resume, and partial setup failures; server/client worker paths now resolve endpoint configs and apply per-client request timeouts.
Migrates endpoint registries to a preferred TOML format (
configs/endpoints.toml) while keeping.pysupport, changesEndpointsto map ids to lists of variants, addsendpoint_idsupport in eval TOML configs, removes support forapi_base_urllists, and updates docs/config samples and the default--endpoints-pathaccordingly.Written by Cursor Bugbot for commit e103f3c. This will update automatically on new commits. Configure here.