re-raise auth errs + fix overlong prompt err for openrouter#813
Merged
re-raise auth errs + fix overlong prompt err for openrouter#813
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
one small convenience feature + buf fix:
AuthenticationErrorwhich will immediately kill the environment process (e.g. in vf-eval the server exits) which is the more desirable "fail" loudly behavior as its completely unrecoverable. currently, we run through all rollouts requests and mark an authentication in eachvf.OverlongPromptErrorto also work for OpenRouter which hadthis endpoint's context [...]instead ofthis model's context [...]which we were matching beforeType of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Low Risk
Low risk: localized error-handling changes around model API calls; primary impact is different exception propagation/typing on auth and bad-request failures.
Overview
Model-call error handling in
Environment.get_model_responseis adjusted to fail fast onopenai.AuthenticationErrorby re-raising it instead of wrapping it, so unrecoverable auth failures terminate immediately.Overlong-prompt detection is broadened by matching more generic context-length phrases (not tied to "this model's" wording), and
BadRequestErrors that aren’t context-length related are now consistently wrapped asvf.ModelError.Written by Cursor Bugbot for commit 0d4b766. This will update automatically on new commits. Configure here.