verifiers: fix tool call rendering from saved outputs#802
Merged
Conversation
verifiers/utils/message_utils.py
Outdated
|
|
||
| def normalize_tool_call(tc: Any) -> dict[str, str]: | ||
| if isinstance(tc, str): | ||
| tc = json.loads(tc) |
There was a problem hiding this comment.
Unhandled JSON parse error in tool call normalization
Medium Severity
The new normalize_tool_call function calls json.loads(tc) when tc is a string, but this call is not wrapped in a try-except block. If a malformed JSON string is encountered (e.g., corrupted data, old format, or encoding issues), a json.JSONDecodeError will be raised and propagate up, potentially crashing the TUI display. This is inconsistent with the defensive handling of json.dumps(args) later in the same function, which is wrapped in a try-except.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since tools are json-serialized, they are no longer correctly displayed in the tui:
This PR fixes that problem:
Type of Change
Testing
uv run pytestlocally.Checklist
Note
Low Risk
Low risk refactor/bugfix limited to Rich formatting utilities and call sites; main risk is minor display regressions or unexpected tool-call string shapes causing JSON decode errors.
Overview
Fixes Rich/TUI rendering of prompts/completions when
tool_callsare stored as JSON strings by introducing a sharedformat_messages()helper that deserializes and pretty-prints tool calls.Removes duplicated message-formatting code in
eval_display.pyandlogging_utils.pyand switches both to the new shared formatter to keep prompt/completion display consistent.Written by Cursor Bugbot for commit c684082. This will update automatically on new commits. Configure here.