Merged
Conversation
c8bb765 to
a38022a
Compare
mikasenghaas
commented
Jan 28, 2026
Member
Author
|
Member
|
I think removing the scoring concurrency is fine. Users can make this part of their rubrics if they want (via class_objects or globals), have used this for multi-part judge rubrics + works well. |
willccbb
reviewed
Jan 28, 2026
willccbb
reviewed
Jan 28, 2026
willccbb
reviewed
Jan 28, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
willccbb
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
EnvClientandEnvServerwhich expose therun_rolloutandrun_groupmethods of an environment from a separate process (pool). This is especially useful for multi-env training (e.g. inprime-rl) and multi-env evals (e.g. invf-evalor online evals).Example
Runnning
vf-evalwill spawn environments in env-server mode by defaultDesign
Env Server Mode
You can put an environment into "env server mode" by calling
This will implicitly start an env server as a sidecar (in a subprocess) and try to route all calls to
run_rolloutandrun_groupto the env server.EnvServer
A
EnvServeris initialized like a regular environment with anenv_idandenv_argsEnvClient
A
EnvClientcommunicates with a env server over the configuredaddressSidecar Pattern
To sidecar an env server (e.g. from
vf-eval) simply wrap therun_serverclass method in aProcessand connect the client to the same addressMisc Changes
vf.setup_logging(...)supports logging to file now as wellRolloutOutputto be able to display error chains as beforeType of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
High Risk
Introduces a new multiprocess, networked execution path (ZMQ/msgpack) and refactors core rollout scheduling/serialization, which can affect correctness, performance, and cleanup behavior across evaluation runs.
Overview
Adds an environment “server mode” for evaluation/training.
Environmentcan now spawn a sidecarZMQEnvServerprocess and routerun_rollout/run_groupover a newEnvClient/ZMQEnvClientusing ZMQ + msgpack, andvf-evalis updated to start/stop the server around each run.Refactors rollout execution and serialization. Generation/scoring no longer use separate generation vs scoring semaphores; a single concurrency limit is applied via
with_sem, tasks are always cleaned up on exit, andrun_rollout/run_groupnow return pre-serializedRolloutOutputobjects (builder now accumulates outputs, not states).Changes error and logging surfaces. Rollout
erroris now a structuredErrorInfo(type + chain strings) instead of a repr string,ErrorChainstring/repr semantics are swapped to preserve prior displays, and logging supports optional file output; tests/docs/CLI config are updated accordingly. Dependencies addpyzmqandmsgpack.Written by Cursor Bugbot for commit ed2b7d9. This will update automatically on new commits. Configure here.