Propagate RLM stop errors from root and sub tools#797
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make sure all tools (
root_toolsandsub_toolsand thus alsotools) propagatestop_errorstocall_bash/python_repl, so thatStatefulToolEnv's handling ofstop_errorstill works.Type of Change
Testing
uv run pytestlocally.Checklist
Note
Ensures RLM stop errors raised by tools are surfaced to the REPL so
StatefulToolEnvstop conditions trigger correctly.llm_batchbatching, re-raise exceptions that satisfy_should_stop_for_error, instead of swallowing them as error messagesstate_ref["_rlm_stop_error"]when a stop error is detected_call_repl), pop and re-raise_rlm_stop_errorafter code execution to propagate the stop upstreamWritten by Cursor Bugbot for commit 3c92ad5. This will update automatically on new commits. Configure here.