cancel outstanding tasks if one task raises in generate#793
Merged
Conversation
willccbb
approved these changes
Jan 28, 2026
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this fixes orphaned tasks sitting around, when a single task in
generateraises an exception.Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Prevents orphaned async tasks during rollout generation.
Environment.generate, wrap awaiting ofas_completedcoroutines with try/except; on any task exception, cancel all remaining tasks and drain them viaasyncio.gather(..., return_exceptions=True)before re-raisingWritten by Cursor Bugbot for commit 8f3f734. This will update automatically on new commits. Configure here.