Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
mikasenghaas
approved these changes
Jan 28, 2026
| ### RolloutOutput | ||
|
|
||
| ```python | ||
| class RolloutOutput(dict): |
Member
There was a problem hiding this comment.
ah yea funnily enough i had a type very similar to this one initially but then scratched it bc it felt too redundant. basiclly RolloutOutput = State - untyped columns + state columns and so I wasn't sure this justified an entirely new type (that now also has to be synced)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Shifts generation outputs from raw
Stateobjects to serializedRolloutOutputdicts and introduces an incremental results builder for efficient saving and display.RolloutOutputtype and updateGenerateOutputsto useoutputs(replacingstates); update docs and all call sites/tests accordinglyGenerateOutputsBuilderto serialize once, stream progress, compute metadata, and support intermediate saves; final results sorted byexample_idstate_to_output/states_to_outputs, removesanitize_states; validatestate_columnsare JSON-serializable; errors serialized as stringsEnvironment.generate()to build outputs incrementally and adjust progress callbacks to useRolloutOutputeval_utils,eval_display,logging_utils,save_utils) to consume serialized outputs;make_datasetnow builds directly fromoutputsgepa.adapter, RL trainer orchestrator) to the newoutputsschemaWritten by Cursor Bugbot for commit a17a1d1. This will update automatically on new commits. Configure here.