fix retry for invalid model response errors#778
Merged
mikasenghaas merged 2 commits intomainfrom Jan 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
actually catches and retries
InvalidModelResponseError+ adjust semantics for retry count in logsType of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Improves the retry wrapper to correctly surface and retry on model response errors and to provide clearer retry logs.
maybe_retrywitherror_types(defaults toInfraErrorandInvalidModelResponseError) and raises fromstate["error"]for dict/list results viareraise_error_from_stateretrynow uses the configurableerror_types;_raise_error_from_stateremovedErrorChain,print_time, caller name, next sleep, and clearer attempt semanticsasync_utils.pyWritten by Cursor Bugbot for commit 45b2087. This will update automatically on new commits. Configure here.