lazy init locked chromadb instance in wiki-search#765
Merged
mikasenghaas merged 4 commits intomainfrom Jan 22, 2026
Merged
Conversation
hallerite
approved these changes
Jan 22, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
previously,
wiki-searchcould not be loaded in processes on the same machine without deadlocking because it eagerly created a local chroma instance with locks. now, the chroma instance is only initted on first tool call. this allows multiple instances to at least exist (e.g. prime-rl orchestrator loads to obtain dataset + env worker loads to execute env)Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Introduces lazy ChromaDB setup to prevent startup lock contention and enable multiple concurrent
wiki-searchenv instances._get_collectionthat initializes once per process and calls_init_chromaon first usesearch_pagescall; query concurrency still guarded by_get_chroma_semaphore0.1.22and add README changelog entry documenting the changeWritten by Cursor Bugbot for commit c341760. This will update automatically on new commits. Configure here.