Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit tool splitting for RLMEnv and enables root‑REPL tools, with fixed tools and shared infrastructure.
New tool parameters
tools: shared by root and sub‑LLMsroot_tools: root‑REPL onlysub_tools: sub‑LLM onlyShared tools are appended to both root/sub lists, preserving order. Tool ordering is:
llm_batch)toolsroot_tools/sub_tools)Each list is de‑duplicated by name; collisions across different callables raise a clear error. Fixed tools are reserved and cannot be overridden.
Root tools
SerializerRegistry/data_serializers(no separate serializer set).Fixed tool
llm_batchis now a fixed, non‑overridable root tool implemented on the host (not in the worker script).Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Adds root/shared/sub tool model to
RLMEnvwith host-implemented fixed root toolllm_batch, RPC plumbing, and serialization.tools(shared),root_tools(REPL-only),sub_tools(sub-LLM) with deterministic ordering, per-list dedupe, and reserved name checks; exposes only sub tools as OpenAI tools/rollout/{id}/v1/rlm/tools; worker proxies calls and (sandbox) serializes args/results using the existingSerializerRegistry(local uses pickle)Root REPL Tools) and updates sub tool docs (Sub-LLM Tools) in system prompt; storesrlm_shared_tools,rlm_root_tools,rlm_sub_toolsin stateRLMMonitorRubricbuild_custom_serializerreturns specs for sandbox useWritten by Cursor Bugbot for commit db4f88a. This will update automatically on new commits. Configure here.