Conversation
|
Approved, good to merge when Tunnels land in prod |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| self.tunnel = Tunnel(local_port=self.interception_port) | ||
| url = await self.tunnel.start() | ||
| logger.debug(f"Prime Tunnel started: {url}") | ||
| return url |
There was a problem hiding this comment.
Missing URL validation on first tunnel start path
Medium Severity
In get_tunnel_url(), the first call path returns url from tunnel.start() without validation, while subsequent calls assert self.tunnel.url is not None before returning. If start() returns None or empty string, the first rollout gets a broken interception_base_url like "None/rollout/.../v1", causing silent failures. Subsequent rollouts would crash with AssertionError. The asymmetric validation suggests awareness of this edge case, but the check is missing on the first path.
Description
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Introduces Prime Tunnel and modernizes agent execution and interception.
prime-tunnel(single managedTunnel, start/stop via API); add dependency and UV git sourceBackgroundJoband poll its status, capturingstdout/stderrand exit code; remove nohup/file-sentinel logicChatCompletion(including tool calls); always unblock HTTP handlers/health, add longer OpenAI/HTTPX timeouts in env vars, and always use statemodelover intercepted payload modelWritten by Cursor Bugbot for commit cc63f75. This will update automatically on new commits. Configure here.